Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-110: Fix verify action that fails if the PR title has apostrophe in it #21

Merged
merged 38 commits into from
Aug 4, 2022
Merged

OSOE-110: Fix verify action that fails if the PR title has apostrophe in it #21

merged 38 commits into from
Aug 4, 2022
+84 −12

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Jun 30, 2022 •
edited
Loading

@sarahelsaig
Make the title a step environment variable, so it doesn't need to be …
0eabe53 
…escaped.
@sarahelsaig
Call Update-ManifestVersion
8e2c989
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
58fa418
@sarahelsaig
Optional nuspec generation via pwsh script.
9e6896f
@sarahelsaig
Rewrite to pack each of the solution's projects separately.
9aedbb3
@sarahelsaig
Some random code cleanup.
a825d3a
@sarahelsaig
Refactor pack logic into script.
78e31cd
@sarahelsaig
Revert "Some random code cleanup."
ea6ecac 
This reverts commit a825d3a.
@sarahelsaig
Update target branch.
abdc4cf
@sarahelsaig
Fix typo.
33db42d
@sarahelsaig
Fix NuspecProperties
d5179f8
@sarahelsaig
Add before pack hook.
afa9f86
@sarahelsaig
Fix "No newline at end of file".
4f62c5c
@sarahelsaig
Whitelist NU5100.
e3ff0b8
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
3c85210
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
254c588
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
9da1790
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
8d898c0 
# Conflicts:
#	.github/actions/publish-nuget/action.yml
@sarahelsaig
Handle special case when no errors were displayed at all.
5801fad
@sarahelsaig
Test double building, just as a sanity check.
352ac78
@sarahelsaig
Select correct branch from workflow
560dff1
@sarahelsaig
Revert "Test double building, just as a sanity check."
65f76ab 
This reverts commit 352ac78.
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-110
d86196a
@sarahelsaig
Add LombiqNetAnalyzers target execution.
7aa87ff
@sarahelsaig
Don't out-null just yet
c30bcc4
@sarahelsaig
Suppress again.
89118d3
@sarahelsaig
Restore as well.
7690a86
0liver
0liver suggested changes Aug 1, 2022
View reviewed changes
.github/actions/build-dotnet/Build-DotNetSolution.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/action.yml Outdated Show resolved Hide resolved
.github/actions/publish-nuget/action.yml Outdated Show resolved Hide resolved
.github/actions/publish-nuget/action.yml Show resolved Hide resolved
.github/actions/publish-nuget/New-NugetPackages.ps1 Outdated Show resolved Hide resolved
.github/actions/verify-submodule-pull-request/action.yml Outdated Show resolved Hide resolved
.github/workflows/test-analysis-failure.yml Show resolved Hide resolved
.github/actions/publish-nuget/action.yml Show resolved Hide resolved
.github/actions/publish-nuget/action.yml Outdated Show resolved Hide resolved
0liver
0liver suggested changes Aug 2, 2022
View reviewed changes
.github/workflows/test-analysis-failure.yml Show resolved Hide resolved
.github/actions/publish-nuget/New-NugetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NugetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/verify-submodule-pull-request/action.yml Outdated Show resolved Hide resolved
@0liver 0liver merged commit 76e4c89 into dev Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0liver 0liver 0liver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahelsaig @0liver