OSOE-597: Breaking API change detector during NuGet publishing #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wAsnk
commented
Oct 9, 2023
Comment on lines
185
to
206
| - name: Push with dotnet | ||
| shell: pwsh | ||
| run: dotnet nuget push artifacts/*.nupkg --api-key $Env:API_KEY --source '${{ steps.setup.outputs.source-url }}' --skip-duplicate | ||
|
|
||
| - name: Publish Artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: NuGet-Package | ||
| path: artifacts | ||
| retention-days: ${{ inputs.nuget-artifact-retention-days }} | ||
|
|
||
| # This is not in its own action because it's all very specific to this NuGet publishing. | ||
| - name: Create Release | ||
| # v1.11.2 | ||
| uses: ncipollo/release-action@18eadf9c9b0f226f47f164f5373c6a44f0aae169 | ||
| # This is to prevent creating releases when pushing tags for issue-specific pre-releases like | ||
| # v4.3.1-alpha.osoe-86. | ||
| if: "!contains(steps.setup.outputs.publish-version, '-')" | ||
| with: | ||
| allowUpdates: true | ||
| generateReleaseNotes: true | ||
| artifacts: artifacts/*.nupkg, artifacts/*.snupkg |
There was a problem hiding this comment.
Removed this part until testing, so NuGet packages are not published. When the reviewer is done I'll restore this part.
sarahelsaig
requested changes
Oct 9, 2023
|
Approved. Please revert #264 (comment) and then you can go ahead and merge too. |
Please approve the PR otherwise the Validate GitHub Actions Refs check will fail. |
sarahelsaig
approved these changes
Oct 11, 2023
|
|
|
This was fun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-597
Fixes #220