OSOE-833: Upgrade PSScriptAnalyzer to 1.22 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Approve/Merge PR)" in the validate-this-gha-refs workflow, because it's not relevant for this PR
…m necessary anymore" This reverts commit f652649.
# Conflicts: # .github/actions/test-dotnet/Invoke-SolutionTests.ps1
sarahelsaig
reviewed
May 15, 2024
Comment on lines
113
to
114
| if: (github.event_name == 'pull_request' || (github.event_name == 'pull_request_review' && github.event.review.state == 'approved') || github.event_name == 'merge_group') && steps.add-prefix.outputs.prefixed-files != '@()' | ||
| # if: (github.event_name == 'pull_request' || (github.event_name == 'pull_request_review' && github.event.review.state == 'approved') || github.event_name == 'merge_group') && steps.add-prefix.outputs.prefixed-files != '@()' | ||
| if: false |
There was a problem hiding this comment.
What's up with this change?
There was a problem hiding this comment.
nvm, I guess this is wha the "Revert all action/workflow changes, except the list of expected analyzer violations" referred to.
There was a problem hiding this comment.
Yup! It was because the script changes were detected by this workflow, but for this PR these are not relevant: https://github.com/Lombiq/GitHub-Actions/actions/runs/9096580468
sarahelsaig
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-833