From 7438480c66a6f4e82c1f74ffaa1d3281e79e8d95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 24 Jul 2024 21:15:31 +0200 Subject: [PATCH 1/4] Quoting --filter for dotnet test, so the filter expression won't break the CLI --- .github/actions/test-dotnet/Invoke-SolutionTests.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/test-dotnet/Invoke-SolutionTests.ps1 b/.github/actions/test-dotnet/Invoke-SolutionTests.ps1 index 4e2f0680e..6119b89d3 100644 --- a/.github/actions/test-dotnet/Invoke-SolutionTests.ps1 +++ b/.github/actions/test-dotnet/Invoke-SolutionTests.ps1 @@ -206,7 +206,7 @@ foreach ($test in $tests) '--logger', '''console;verbosity=detailed''' '--verbosity', $Verbosity $BlameHangTimeout ? ('--blame-hang-timeout', $BlameHangTimeout, '--blame-hang-dump-type', 'full') : '' - $Filter ? '--filter', $Filter : '' + $Filter ? '--filter', "'$Filter'" : '' $EnableDiagnosticMode ? '--diag DiagnosticLogs/dotnet-test.log' : '' $test ) From 3b243d25c6e37f77204195811796e8cca86680c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 24 Jul 2024 21:15:42 +0200 Subject: [PATCH 2/4] Pointing GHA to issue branch --- .github/workflows/build-and-test-dotnet.yml | 2 +- .github/workflows/build-and-test-orchard-core.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-test-dotnet.yml b/.github/workflows/build-and-test-dotnet.yml index afd688e1b..5cb7e3ef6 100644 --- a/.github/workflows/build-and-test-dotnet.yml +++ b/.github/workflows/build-and-test-dotnet.yml @@ -246,7 +246,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests with: blame-hang-timeout: ${{ inputs.blame-hang-timeout }} build-directory: ${{ inputs.build-directory }} diff --git a/.github/workflows/build-and-test-orchard-core.yml b/.github/workflows/build-and-test-orchard-core.yml index ba38b10f3..eea4e85e5 100644 --- a/.github/workflows/build-and-test-orchard-core.yml +++ b/.github/workflows/build-and-test-orchard-core.yml @@ -300,7 +300,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests with: blame-hang-timeout: ${{ inputs.blame-hang-timeout }} build-directory: ${{ inputs.build-directory }} From ae70d6c8902c85f20e040e19f1823144d3862683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 24 Jul 2024 21:17:51 +0200 Subject: [PATCH 3/4] Pointing GHA to issue branch --- .github/workflows/msbuild-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/msbuild-and-test.yml b/.github/workflows/msbuild-and-test.yml index 01c2fdabb..74e779f5b 100644 --- a/.github/workflows/msbuild-and-test.yml +++ b/.github/workflows/msbuild-and-test.yml @@ -138,7 +138,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests with: build-directory: ${{ inputs.build-directory }} dotnet-test-process-timeout: ${{ inputs.dotnet-test-process-timeout }} From 150b019c160621da9d57f7096bec3ec7ad7acf2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Thu, 25 Jul 2024 01:46:06 +0200 Subject: [PATCH 4/4] Reverting issue branch references for GHA [skip ci] --- .github/workflows/build-and-test-dotnet.yml | 2 +- .github/workflows/build-and-test-orchard-core.yml | 2 +- .github/workflows/msbuild-and-test.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-and-test-dotnet.yml b/.github/workflows/build-and-test-dotnet.yml index 5cb7e3ef6..afd688e1b 100644 --- a/.github/workflows/build-and-test-dotnet.yml +++ b/.github/workflows/build-and-test-dotnet.yml @@ -246,7 +246,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev with: blame-hang-timeout: ${{ inputs.blame-hang-timeout }} build-directory: ${{ inputs.build-directory }} diff --git a/.github/workflows/build-and-test-orchard-core.yml b/.github/workflows/build-and-test-orchard-core.yml index eea4e85e5..ba38b10f3 100644 --- a/.github/workflows/build-and-test-orchard-core.yml +++ b/.github/workflows/build-and-test-orchard-core.yml @@ -300,7 +300,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev with: blame-hang-timeout: ${{ inputs.blame-hang-timeout }} build-directory: ${{ inputs.build-directory }} diff --git a/.github/workflows/msbuild-and-test.yml b/.github/workflows/msbuild-and-test.yml index 74e779f5b..01c2fdabb 100644 --- a/.github/workflows/msbuild-and-test.yml +++ b/.github/workflows/msbuild-and-test.yml @@ -138,7 +138,7 @@ jobs: - name: Tests if: inputs.test-disable == 'false' - uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@bug/no-edge-tests + uses: Lombiq/GitHub-Actions/.github/actions/test-dotnet@dev with: build-directory: ${{ inputs.build-directory }} dotnet-test-process-timeout: ${{ inputs.dotnet-test-process-timeout }}