Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-156: Code styling #62

Merged
merged 16 commits into from
Oct 6, 2022
Merged

OSOE-156: Code styling #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
478f79a
Enabling Git longpaths
Piedone Oct 3, 2022
96d29c7
Issue link
Piedone Oct 3, 2022
8c09f66
Only set git longpaths under Windows
Piedone Oct 3, 2022
00630c7
Full docker CLI parameter names for better readability
Piedone Oct 3, 2022
8fe6fd7
Alternative SQL Server-installing login under Linux
Piedone Oct 3, 2022
c7aaf11
Starting with SQL Server setup as a start
Piedone Oct 3, 2022
271b206
Back to Docker SQL Server installation under Linux
Piedone Oct 3, 2022
bc1b613
Waiting 30 cycles for SQL Server startup, perhaps it'll work
Piedone Oct 3, 2022
8cbc8b5
Pointing to the action in the issue branch
Piedone Oct 3, 2022
bcb3478
Code styling
Piedone Oct 3, 2022
5f185dd
Revert "Waiting 30 cycles for SQL Server startup, perhaps it'll work"
Piedone Oct 4, 2022
80b390a
Removing build-and-test-orchard-core.yml changes
Piedone Oct 4, 2022
dc5f766
Code styling
Piedone Oct 4, 2022
b6a91bc
Pointing to action in branch
Piedone Oct 4, 2022
44397b6
Code styling
Piedone Oct 5, 2022
0428c17
Another longer command switch
Piedone Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/actions/setup-sql-server/Initialize-SqlServer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
if ($Env:RUNNER_OS -eq "Windows")
if ($Env:RUNNER_OS -eq "Windows")
{
choco install sql-server-express --no-progress
}
else
{
docker pull mcr.microsoft.com/mssql/server &&
docker run --name sql2019 -e 'ACCEPT_EULA=Y' -e 'SA_PASSWORD=Password1!' -p 1433:1433 -d 'mcr.microsoft.com/mssql/server:2019-latest' &&
docker exec -u 0 sql2019 bash -c 'mkdir /data; chmod 777 /data -R; chown mssql:root /data'
docker run `
--name sql2019 `
--env 'ACCEPT_EULA=Y' `
--env 'SA_PASSWORD=Password1!' `
--publish 1433:1433 `
--detach 'mcr.microsoft.com/mssql/server:2019-latest' &&
docker exec --user 0 sql2019 bash -c 'mkdir /data; chmod 777 /data --recursive; chown mssql:root /data'
}
1 change: 1 addition & 0 deletions .github/actions/setup-sql-server/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ runs:
shell: pwsh
run: |
"${{ github.action_path }}" >> $Env:GITHUB_PATH

- name: Set up SQL Server
shell: pwsh
run: Initialize-SqlServer
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/verify-submodule-pull-request/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
- name: Setup and Print PR Title
shell: pwsh
run: |
echo "Pull Request Title: ${{ inputs.title }}"
Write-Output "Pull Request Title: ${{ inputs.title }}"

"${{ github.action_path }}" >> $Env:GITHUB_PATH

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-orchard-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
cache-version: ${{ inputs.build-cache-version }}

- name: Set up SQL Server
uses: Lombiq/GitHub-Actions/.github/actions/setup-sql-server@dev
uses: Lombiq/GitHub-Actions/.github/actions/setup-sql-server@issue/OSOE-156-code-styling

- name: Set up Azurite
uses: Lombiq/GitHub-Actions/.github/actions/setup-azurite@dev
Expand Down