-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues in target-blank.js (OSOE-576) #116
Comments
github-actions
bot
changed the title
Fix issues in target-blank.js
Fix issues in target-blank.js (OSOE-576)
Feb 20, 2023
From target-blank.js the whole second part can be removed starting with "window.addEventListener...", that makes the "Use DOMContentLoaded event instead of..." part unneccesary, right? |
No. window.addEventListener(
'load',
() => {
window.setTimeout(targetBlank, 100);
},
false); Should become: document.addEventListener('DOMContentLoaded', targetBlank); |
I see, understood. |
Fixed in #117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up to #104.
See comments here and below.
DOMContentLoaded
event instead ofload
. There's no third parameter there.setTimeout
indirection from the event handler. Simply passtargetBlank
as the handler.a.
"nodejsExtensions"
b.
"devDependencies"
Jira issue
The text was updated successfully, but these errors were encountered: