Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the OC package references to 1.8.0 instead of 1.8.2 (OSOE-846) #258

Closed
sarahelsaig opened this issue May 1, 2024 · 4 comments
Closed

Comments

@sarahelsaig
Copy link
Member

sarahelsaig commented May 1, 2024

Based on @Piedone 's advice in OCC:

I think the OCC packages should always target the .0 minor version of the latest version; i.e., 1.8.0 in this case, so people can use the packages regardless of them being on 1.8.0, 1.8.1, 1.8.2, or 1.8.3 (currently they're forced to use at least 1.8.2). During development and testing though, we should use the very latest, if somehow this can be done.

This is not possible for the projects that use HL, specifically OrchardCore.Commerce.Inventory and OrchardCore.Commerce.ContentFields.

Once this is done, also update OCC's Directory.Packages.props as suggested here.

Jira issue

@github-actions github-actions bot changed the title Change the OC package references to 1.8.0 instead of 1.8.2 Change the OC package references to 1.8.0 instead of 1.8.2 (OSOE-846) May 1, 2024
@Piedone
Copy link
Member

Piedone commented May 1, 2024

This would require us to disable package consolidation checks for OC versions.

@Piedone
Copy link
Member

Piedone commented May 17, 2024

So, we'd need to always update the consolidation check disable regex to the current baseline OC version, i.e. the one we use in all shared projects (not web projects). However, something like "2.1" is not really unique, so we risk missing actual consolidation errors too.

We could also extend dotnet-consolidate with an option to exclude projects or packages from consolidation by regex (the -e option can exclude packages, but you need to list them all; we can do that, but we'd need to generate a list of 190 OC packages).

@sarahelsaig
Copy link
Member Author

It would be good to exclude the "main" (*.Web.csproj) project from consolidation since that's where all the custom project versions will reside. This may be done in GHA:

  • Add an option to specify project file(s) to exclude
  • Use dotnet sln solution.sln remove excluded.csproj to remove each excluded project from the solution file
  • Run dotnet-consolidate
  • Use git reset --hard to restore the solution

@Piedone
Copy link
Member

Piedone commented May 17, 2024

Hmm, interesting, indeed! We need to do this holistically, not in this project, so this instead: Lombiq/GitHub-Actions#354.

@Piedone Piedone closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants