Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer runs before Node.js Extensions compiles the assets (OSOE-674) #43

Closed
barthamark opened this issue Aug 22, 2023 · 3 comments
Closed

Comments

@barthamark
Copy link
Member

barthamark commented Aug 22, 2023

Deployer runs before Node.js Extensions compiles the assets so it won't create the necessary Media steps in the Media Theme recipe. The workaround is to commit the content of wwwroot.

Jira issue

@github-actions github-actions bot changed the title Deployer runs before Node.js Extensions compiles the assets Deployer runs before Node.js Extensions compiles the assets (OSOE-674) Aug 22, 2023
@Piedone
Copy link
Member

Piedone commented Aug 22, 2023

How do you run the Deployer?

@barthamark
Copy link
Member Author

barthamark commented Aug 22, 2023

I'm importing the Lombiq.Hosting.MediaTheme.Targets.props and targets files in the theme's csproj. It executes the following target before build:
<Target Name="RunMediaThemeDeployer" BeforeTargets="BeforeBuild"> <Exec Command="dotnet media-theme-deploy --path . --base-id $(MediaThemeBaseId) --clear true --deployment-path $(DeploymentFolder) --deployment-file-name $(MediaThemeRecipeFileName)"/> </Target>

@Piedone
Copy link
Member

Piedone commented Aug 22, 2023

This is the issue with that project then. The Deployer doesn't have anything to do with compilation. You need to change that project to execute the Deployer at a better time in the build pipeline.

@Piedone Piedone closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants