Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to open the Logs folder in Windows Explorer (VSIX-49) #3

Open
BenedekFarkas opened this issue Aug 11, 2017 · 1 comment

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Aug 11, 2017

When there are no unseen additions in the error log (i.e. the red dot indicator is inactive), clicking the Orchard icon could open the file explorer in the Logs folder.

Jira issue

@Piedone
Copy link
Member

Piedone commented Mar 30, 2020

I briefly look into this and it's not as simple as I thought. We need the following:

  • A new icon for the button's enabled but not "new log entry" state (there is an Orchard logo icon in the app but it's grey-ish, not green as the base or the icon with the red dot).
  • Change icons on the fly. OpenErrorLogCommand currently only enables/disables itself to change state but it'd need to change icons as well. However, this is not possible and instead we'll need to use two commands and swap their visibility.
  • Somehow manage the states apart from the log file not existing and having been updated, also that it can simply exist or not and how this changes. The good news is that ILogFileWatchers already handle this and OpenErrorLogCommand.LogFileUpdatedCallback() will be called when a new log file is created but it's empty.

@github-actions github-actions bot changed the title Feature request: Ability to open the Logs folder in Windows Explorer Feature request: Ability to open the Logs folder in Windows Explorer (VSIX-49) Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants