-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles and scripts give 404 when deployed unless the default configuration is repeated (OSOE-877) #104
Comments
I'm not sure how to test this, but would deployment work even if you only provide this much? {
...
"nodejsExtensions": {
"styles": { },
"scripts": { }
}
} I'm certain that if the style/script build starts, then the config will correctly get the default values in get-config.js. So I get a sense that maybe the build only triggers if there is a config? |
I've sent you a PM on how you can test it with one of our apps (I can't really test it right now) but perhaps you're on the right track. |
Where? I don't see it. |
I'll give you a hint: it starts with "Teams" and ends with "". |
Yes, obviously that's where I first checked. I haven't gotten a PM in Teams from you in a long while |
Just check the project channel :). Fair enough, not private, just more private than this here. |
Doesn't work, unfortunately. (I get error |
I see, thank you. |
Supposedly, this is the default config for
styles
andscripts
, so you shouldn't have to add it to your packages.json:However, if you omit this, then the files will give a 404 when deployed (to an Azure Web App, if that matters). The files are properly built otherwise though, locally from VS they still work, as well as when built and run with the .NET CLI during UI testing in CI workflows.
Specifying these defaults shouldn't be necessary.
Jira issue
The text was updated successfully, but these errors were encountered: