Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use UseGlobalNodeJsExtensionsNpmPackage when used from NuGet (OSOE-914) #108

Open
Piedone opened this issue Nov 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Piedone
Copy link
Member

Piedone commented Nov 3, 2024

When the project is used from NuGet, using the below config:

<UseGlobalNodeJsExtensionsNpmPackage>true</UseGlobalNodeJsExtensionsNpmPackage>
<NodeJsExtensionsNpmPackageSourcePath>$(MSBuildThisFileDirectory)node_modules/.nx</NodeJsExtensionsNpmPackageSourcePath>

Will result in a build error like:

ΓÇëERR_PNPM_NO_IMPORTER_MANIFEST_FOUNDΓÇë No package.json (or package.yaml, or package.json5) was found in "path\to\solution\node_modules/.nx".

This should still work, like it does when using the project as a submodule.

Configure the NuGetTest solution like this too. Currently, it disables UseGlobalNodeJsExtensionsNpmPackage deliberately (as does Lombiq.NodeJs.Extensions.Samples.NuGet, but it needs that, see the comment there). Make the Lombiq.OSOCE.NuGet.TestTheme theme there use NE to build the trivial SCSS file that's actually already there, but that doesn't do anything.

Jira issue

@Piedone Piedone added the bug Something isn't working label Nov 3, 2024
@github-actions github-actions bot changed the title Can't use UseGlobalNodeJsExtensionsNpmPackage when used from NuGet Can't use UseGlobalNodeJsExtensionsNpmPackage when used from NuGet (OSOE-914) Nov 3, 2024
@Piedone
Copy link
Member Author

Piedone commented Nov 3, 2024

Perhaps something you'd be interested in, @sarahelsaig?

@Piedone
Copy link
Member Author

Piedone commented Nov 26, 2024

@sarahelsaig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant