Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NuGetTest updates better (OSOE-816) #706

Open
Piedone opened this issue Feb 19, 2024 · 0 comments
Open

Make NuGetTest updates better (OSOE-816) #706

Piedone opened this issue Feb 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Feb 19, 2024

This is not a fully planned out suggestion, more of a problem statement and opener to think together.

When you change an OSOCE project today, you don't have to publish an alpha NuGet package. This is OK, since not every change warrants an alpha due to it being used in another NuGet solution (or things like docs or sample changes don't need a NuGet release ever).

However, this results in versions used in the NuGetTest package gradually going out of date. That is, until an OC upgrade requires an update to every project, when all potential breaking changes will arrive at once, and you have to fix the NuGetTest solution. Or a project's NuGet publish may fail as well, e.g. due to incomplete project-package references, or something breaking due to the Node build.

A couple of ideas on how to tackle this:

  • Require a NuGet release before approving every submodule PR, if the changes in that PR affect the NuGet package (excluding e.g. the mentioned samples or docs changes). However, this is a chore.
  • Run a NuGet package creation, but without publishing to NuGet.org, for every submodule commit, kind of like a CI build. This would at least prevent introducing NuGet publishing errors. - This is now down by Automatically check baseline package validation during review (OSOE-864) GitHub-Actions#359.

Related issues that might help here: #703 and Lombiq/GitHub-Actions#70.

Jira issue

@Piedone Piedone added the enhancement New feature or request label Feb 19, 2024
@github-actions github-actions bot changed the title Make NuGetTest updates better Make NuGetTest updates better (OSOE-816) Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant