JSON Content Editor #634
Merged
JSON Content Editor #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is only red because "Add Windows Build Warning Label" fails with |
|
Hehh, ironic: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/7092830642/workflow#L90 I think it trips on the unusual combination of your user being part of the Lombiq org but this coming from a fork (and it would work for a fork when opened by an outsider, when we have to approve the run first). |
Piedone
approved these changes
Dec 5, 2023
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
…Source-Orchard-Core-Extensions into content-editor # Conflicts: # src/Modules/Lombiq.JsonEditor
Piedone
approved these changes
Dec 12, 2023
Piedone
reviewed
Dec 12, 2023
| @@ -40,7 +40,7 @@ | |||
| branch = dev | |||
| [submodule "src/Modules/Lombiq.JsonEditor"] | |||
| path = src/Modules/Lombiq.JsonEditor | |||
| url = https://github.com/Lombiq/Orchard-JSON-Editor.git | |||
| url = https://github.com/sarahelsaig/Orchard-JSON-Editor.git | |||
There was a problem hiding this comment.
Note to self: revert or don't merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content change and details in submodule Lombiq/Orchard-JSON-Editor#54