Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEST-536: Update OC #829

Merged
merged 39 commits into from
Aug 23, 2024
Merged

NEST-536: Update OC #829

merged 39 commits into from
Aug 23, 2024

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Jul 29, 2024 •
edited by jira bot
Loading

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@sarahelsaig sarahelsaig changed the base branch from dev to task/system-text-json-migration July 29, 2024 21:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Piedone
Piedone requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK apart from the build failing.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sarahelsaig sarahelsaig merged commit 9b4dea9 into task/system-text-json-migration Aug 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
requires-windows-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahelsaig @Piedone @LombiqBot