diff --git a/NuGetTest/Directory.Build.props b/NuGetTest/Directory.Build.props index 9c4129f3f..c10d629e7 100644 --- a/NuGetTest/Directory.Build.props +++ b/NuGetTest/Directory.Build.props @@ -1,12 +1,8 @@ true - false - - - $(MSBuildThisFileDirectory).. - $(MSBuildThisFileDirectory).. + true + $(MSBuildThisFileDirectory)node_modules/.nx diff --git a/Readme.md b/Readme.md index c4740d30f..a374eea10 100644 --- a/Readme.md +++ b/Readme.md @@ -128,6 +128,11 @@ When adding a new extension, or significant new features to existing extensions, - Open a pull request in this repository for every submodule pull request. That way, static code analysis and complex tests can run. If you forget to do so, a check in the submodule will fail. Once you've created the PR here, just click "Re-run jobs" in your submodule. - If you see build errors under your pull request then check out its details: It will send you to the failed step in the Actions tab. You can also click on the "Summary" on the sidebar to download the artifacts (logs, screenshots, etc) and in case of failed UI tests you find the annotations linking to which test failed. - Open a pull request for all but trivial changes (like typos) so we can nicely track them, including when generating release notes for the next release. +- If you introduce breaking changes, the Validate NuGet Publish workflow will fail due to [baseline package validation](https://learn.microsoft.com/en-us/dotnet/fundamentals/apicompat/package-validation/baseline-version-validator). Preferably, adjust the change to not be breaking if possible; if it has to be a breaking change, then you’ll need to create a _CompatibilitySuppressions.xml_ file to mark it as deliberate, what you can do with the following command: + +```powershell +dotnet pack /p:EnablePackageValidation=true /p:PackageValidationBaselineVersion= /p:Version= /p:NuGetBuild=true /p:GenerateCompatibilitySuppressionFile=true +``` ### Dependencies between Lombiq projects diff --git a/src/Modules/Lombiq.AuditTrailExtensions b/src/Modules/Lombiq.AuditTrailExtensions index 21b9bfadf..36bd3e210 160000 --- a/src/Modules/Lombiq.AuditTrailExtensions +++ b/src/Modules/Lombiq.AuditTrailExtensions @@ -1 +1 @@ -Subproject commit 21b9bfadf3c40f05ed5b64032c3351a1f4690704 +Subproject commit 36bd3e210d91b2abff08538d8b58ab66ff524450 diff --git a/src/Modules/Lombiq.HelpfulExtensions b/src/Modules/Lombiq.HelpfulExtensions index 41923cba7..fee9dba96 160000 --- a/src/Modules/Lombiq.HelpfulExtensions +++ b/src/Modules/Lombiq.HelpfulExtensions @@ -1 +1 @@ -Subproject commit 41923cba7b34b178506a51e3327239e30234c897 +Subproject commit fee9dba967b49bf512d861f2d8a845c645290ce8 diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index 05edb4585..b0344df2e 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit 05edb4585806d8f73977081ec182c31bee452869 +Subproject commit b0344df2ef35c58b997c28aeec87bbc5e846fa2b