From 6d3caa597fa455e0f018355c16ba98ce481c3173 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 25 Oct 2024 14:25:03 +0200 Subject: [PATCH 1/8] Docs --- tools/Lombiq.GitHub.Actions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index 239f3d5f9..02485ae6b 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit 239f3d5f984e449beda4ec4e5f495dbf0feb0cc5 +Subproject commit 02485ae6b365fd0a6c1e793baf8a12973ae3dbd2 From 6dda21616ab75d5dc3b6273a6df204d9bdda0230 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 1 Nov 2024 21:22:20 +0100 Subject: [PATCH 2/8] Updating check-spelling to v0.0.24 --- .github/workflows/build-and-test.yml | 2 +- tools/Lombiq.GitHub.Actions | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 058966db8..55c3fbb89 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -49,7 +49,7 @@ jobs: spelling: name: Spelling - uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev + uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@issue/OSOE-864 with: additional-dictionaries: | cspell:csharp/csharp.txt diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index 5947df9b3..efdc63291 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit 5947df9b3f352b42e55ce43d08c1b7ea9bddfe9f +Subproject commit efdc63291ac73aa5dbd79a2649e0b2c0cee71149 From a6e402f2d6d53288c8ce8011046efa1bdc5c3e12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sat, 2 Nov 2024 01:39:36 +0100 Subject: [PATCH 3/8] Implementing NuGet publish validation --- src/Modules/Lombiq.AuditTrailExtensions | 2 +- tools/Lombiq.GitHub.Actions | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Modules/Lombiq.AuditTrailExtensions b/src/Modules/Lombiq.AuditTrailExtensions index 21b9bfadf..29acde326 160000 --- a/src/Modules/Lombiq.AuditTrailExtensions +++ b/src/Modules/Lombiq.AuditTrailExtensions @@ -1 +1 @@ -Subproject commit 21b9bfadf3c40f05ed5b64032c3351a1f4690704 +Subproject commit 29acde326587351f7ef16b2c913a6bc5c39787f0 diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index efdc63291..7780a0a77 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit efdc63291ac73aa5dbd79a2649e0b2c0cee71149 +Subproject commit 7780a0a775c0a101bd00bd27cce45b5b1eb6b56c From 169cba14d1a3888a679463b6163e196e760c88e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 3 Nov 2024 01:29:04 +0100 Subject: [PATCH 4/8] Fixing HE PNPM lock file --- src/Modules/Lombiq.HelpfulExtensions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/Lombiq.HelpfulExtensions b/src/Modules/Lombiq.HelpfulExtensions index 41923cba7..daac65c73 160000 --- a/src/Modules/Lombiq.HelpfulExtensions +++ b/src/Modules/Lombiq.HelpfulExtensions @@ -1 +1 @@ -Subproject commit 41923cba7b34b178506a51e3327239e30234c897 +Subproject commit daac65c73a7b0f4b106ecca3c0a259fbf9114e9a From de261fdd2eeaf4e444c324273ad84ec7cd5785ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 3 Nov 2024 01:29:19 +0100 Subject: [PATCH 5/8] Trying global NE NPM install in NuGetTest --- NuGetTest/Directory.Build.props | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/NuGetTest/Directory.Build.props b/NuGetTest/Directory.Build.props index 9c4129f3f..c10d629e7 100644 --- a/NuGetTest/Directory.Build.props +++ b/NuGetTest/Directory.Build.props @@ -1,12 +1,8 @@ true - false - - - $(MSBuildThisFileDirectory).. - $(MSBuildThisFileDirectory).. + true + $(MSBuildThisFileDirectory)node_modules/.nx From 0c3133352a06beca1c763fa8d381b99bfe7f40c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 3 Nov 2024 01:45:47 +0100 Subject: [PATCH 6/8] Docs --- tools/Lombiq.GitHub.Actions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index 7780a0a77..8c16d0920 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit 7780a0a775c0a101bd00bd27cce45b5b1eb6b56c +Subproject commit 8c16d0920e2db4b7422a97c88905c0572a3509ec From 8d06d6ad5292d21d15732fd3a00045f0c79d6e66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 3 Nov 2024 10:58:25 +0100 Subject: [PATCH 7/8] Docs --- Readme.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Readme.md b/Readme.md index c4740d30f..a374eea10 100644 --- a/Readme.md +++ b/Readme.md @@ -128,6 +128,11 @@ When adding a new extension, or significant new features to existing extensions, - Open a pull request in this repository for every submodule pull request. That way, static code analysis and complex tests can run. If you forget to do so, a check in the submodule will fail. Once you've created the PR here, just click "Re-run jobs" in your submodule. - If you see build errors under your pull request then check out its details: It will send you to the failed step in the Actions tab. You can also click on the "Summary" on the sidebar to download the artifacts (logs, screenshots, etc) and in case of failed UI tests you find the annotations linking to which test failed. - Open a pull request for all but trivial changes (like typos) so we can nicely track them, including when generating release notes for the next release. +- If you introduce breaking changes, the Validate NuGet Publish workflow will fail due to [baseline package validation](https://learn.microsoft.com/en-us/dotnet/fundamentals/apicompat/package-validation/baseline-version-validator). Preferably, adjust the change to not be breaking if possible; if it has to be a breaking change, then you’ll need to create a _CompatibilitySuppressions.xml_ file to mark it as deliberate, what you can do with the following command: + +```powershell +dotnet pack /p:EnablePackageValidation=true /p:PackageValidationBaselineVersion= /p:Version= /p:NuGetBuild=true /p:GenerateCompatibilitySuppressionFile=true +``` ### Dependencies between Lombiq projects From dc4322246e24f02ec80b65da877e1a2f6fdcf371 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A1ra=20El-Saig?= Date: Mon, 4 Nov 2024 16:22:49 +0100 Subject: [PATCH 8/8] submodules --- .github/workflows/build-and-test.yml | 2 +- src/Modules/Lombiq.AuditTrailExtensions | 2 +- src/Modules/Lombiq.HelpfulExtensions | 2 +- tools/Lombiq.GitHub.Actions | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 55c3fbb89..058966db8 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -49,7 +49,7 @@ jobs: spelling: name: Spelling - uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@issue/OSOE-864 + uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev with: additional-dictionaries: | cspell:csharp/csharp.txt diff --git a/src/Modules/Lombiq.AuditTrailExtensions b/src/Modules/Lombiq.AuditTrailExtensions index 29acde326..36bd3e210 160000 --- a/src/Modules/Lombiq.AuditTrailExtensions +++ b/src/Modules/Lombiq.AuditTrailExtensions @@ -1 +1 @@ -Subproject commit 29acde326587351f7ef16b2c913a6bc5c39787f0 +Subproject commit 36bd3e210d91b2abff08538d8b58ab66ff524450 diff --git a/src/Modules/Lombiq.HelpfulExtensions b/src/Modules/Lombiq.HelpfulExtensions index daac65c73..fee9dba96 160000 --- a/src/Modules/Lombiq.HelpfulExtensions +++ b/src/Modules/Lombiq.HelpfulExtensions @@ -1 +1 @@ -Subproject commit daac65c73a7b0f4b106ecca3c0a259fbf9114e9a +Subproject commit fee9dba967b49bf512d861f2d8a845c645290ce8 diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions index 8c16d0920..b0344df2e 160000 --- a/tools/Lombiq.GitHub.Actions +++ b/tools/Lombiq.GitHub.Actions @@ -1 +1 @@ -Subproject commit 8c16d0920e2db4b7422a97c88905c0572a3509ec +Subproject commit b0344df2ef35c58b997c28aeec87bbc5e846fa2b