Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu styling (OSOE-685) #89

Closed
Piedone opened this issue Sep 9, 2023 · 0 comments · Fixed by #90
Closed

Fix menu styling (OSOE-685) #89

Piedone opened this issue Sep 9, 2023 · 0 comments · Fixed by #90
Assignees
@sarahelsaig
Labels
bug Something isn't working

Comments

@Piedone
Copy link
Member

Piedone commented Sep 9, 2023 •
edited by github-actions bot
Loading

At one point, the menu changed from this:
Original

To this:
Current

This is not deliberate, so let's fix it. and add a visual verification test for the homepage to prevent happening again.

According to @DAud-IcI, "Looks like some selector is no longer being applied. (btw not just the color, the "Log in" is not aligned to the right either)" So we need to fix the login item too.

Jira issue
@Piedone Piedone added the bug Something isn't working label Sep 9, 2023
@github-actions github-actions bot changed the title Fix menu styling Fix menu styling (OSOE-685) Sep 9, 2023
@sarahelsaig sarahelsaig self-assigned this Sep 10, 2023
@github-actions github-actions bot mentioned this issue Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahelsaig sarahelsaig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSOE-685: Fix menu styling in Lombiq.BaseTheme Lombiq/Orchard-Base-Theme
2 participants
@Piedone @sarahelsaig