From 8c58730c437ce540374802ff32dce9c991f0015e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B3zsef=20Horv=C3=A1th?= <jozsef.horvath@lombiq.com>
Date: Sun, 12 Nov 2023 12:41:12 +0100
Subject: [PATCH] Apply suggestions from code review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
---
 .../CounterThresholdConfiguration.cs            | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/Lombiq.Tests.UI/Services/Counters/Configuration/CounterThresholdConfiguration.cs b/Lombiq.Tests.UI/Services/Counters/Configuration/CounterThresholdConfiguration.cs
index 75a56d454..72acfcbae 100644
--- a/Lombiq.Tests.UI/Services/Counters/Configuration/CounterThresholdConfiguration.cs
+++ b/Lombiq.Tests.UI/Services/Counters/Configuration/CounterThresholdConfiguration.cs
@@ -8,17 +8,20 @@ public class CounterThresholdConfiguration
     public bool Disable { get; set; } = true;
 
     /// <summary>
-    /// Gets or sets the threshold of executed <see cref="System.Data.Common.DbCommand"/>s. Uses
-    /// <see cref="System.Data.Common.DbCommand.CommandText"/> and <see cref="System.Data.Common.DbCommand.Parameters"/>
-    /// for counting.
+    /// Gets or sets the threshold for the count of <see cref="System.Data.Common.DbCommand"/> executions, with the
+    /// query only counted as a duplicate if both its text (<see cref="System.Data.Common.DbCommand.CommandText"/>) and
+    /// parameters (<see cref="System.Data.Common.DbCommand.Parameters"/>) match. See
+    /// <see cref="DbCommandTextExecutionThreshold"/> for counting using only the command text.
     /// </summary>
-    public int DbCommandExecutionThreshold { get; set; } = 11;
+    public int DbCommandIncludingParametersExecutionCountThreshold { get; set; } = 11;
 
     /// <summary>
-    /// Gets or sets the threshold of executed <see cref="System.Data.Common.DbCommand"/>s. Uses
-    /// <see cref="System.Data.Common.DbCommand.CommandText"/> for counting.
+    /// Gets or sets the threshold for the count of <see cref="System.Data.Common.DbCommand"/> executions, with the
+    /// query counted as a duplicate if its text (<see cref="System.Data.Common.DbCommand.CommandText"/>) matches.
+    /// Parameters (<see cref="System.Data.Common.DbCommand.Parameters"/>) are not taken into account. See
+    /// <see cref="DbCommandExecutionThreshold"/> for counting using also the parameters.
     /// </summary>
-    public int DbCommandTextExecutionThreshold { get; set; } = 11;
+    public int DbCommandExcludingParametersExecutionThreshold { get; set; } = 11;
 
     /// <summary>
     /// Gets or sets the threshold of readings of <see cref="System.Data.Common.DbCommand"/>s. Uses