Skip to content

Commit

Permalink
Revert "Skipping Edge tests"
Browse files Browse the repository at this point in the history
This reverts commit 8a7e8c3.
  • Loading branch information
Piedone committed Nov 21, 2024
1 parent 8a5f37a commit a8426eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ public Task VerifyBlogImage() =>
// is the different rendering of text on each platform, but it can occur between different Linux distributions too.
// Here: https://pandasauce.org/post/linux-fonts/ you can find a good summary about this from 2019, but still valid
// in 2022.
// Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.
[Theory, Chrome]
[Theory, Chrome, Edge]
public Task VerifyNavbar(Browser browser) =>
ExecuteTestAfterSetupAsync(
context =>
Expand Down
7 changes: 2 additions & 5 deletions Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,15 @@ public MultiBrowserTests(ITestOutputHelper testOutputHelper)

// First, let's see a test using Edge. While the default browser is Chrome if you don't set anything, all
// ExecuteTest* methods can also accept a browser, if you want to use a different one.
#pragma warning disable xUnit1004 // Test methods should not be skipped
[Fact(Skip = "Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.")]
#pragma warning restore xUnit1004 // Test methods should not be skipped
[Fact]
public Task AnonymousHomePageShouldExistWithEdge() =>
ExecuteTestAfterSetupAsync(NavbarIsCorrect, Browser.Edge);

// This test is now marked not with the [Fact] attribute but [Theory]. With it, you can create so-called data-driven
// tests. [Chrome] and [Edge] are input parameters of the test, and thus in effect, you have now two tests:
// AnonymousHomePageShouldExistMultiBrowser once with Chrome, and once with Edge. See here for more info:
// https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/.
// Temporarily not running Edge until https://github.com/atata-framework/atata-webdriversetup/issues/16 is fixed.
[Theory, Chrome]
[Theory, Chrome, Edge]
public Task AnonymousHomePageShouldExistMultiBrowser(Browser browser) =>
ExecuteTestAfterSetupAsync(NavbarIsCorrect, browser);

Expand Down

0 comments on commit a8426eb

Please sign in to comment.