Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a version of CultureScope that doesn't have user overrides (OSOE-350) #133

Closed
sarahelsaig opened this issue Feb 21, 2022 · 1 comment · Fixed by #296
Closed

Use a version of CultureScope that doesn't have user overrides (OSOE-350) #133

sarahelsaig opened this issue Feb 21, 2022 · 1 comment · Fixed by #296
Assignees
Labels
enhancement New feature or request

Comments

@sarahelsaig
Copy link
Member

sarahelsaig commented Feb 21, 2022

This is related to OrchardCMS/OrchardCore#11228
The useUserOverride in CultureInfo(string Culture, bool useUserOverride) should be always false in UI tests to make them more reproducible and portable. Depending on how the above linked issue goes, we should either force default configuration or replace it with a custom implementation that uses the method suggested in the issue description.

After this, this line in Data Tables needs to be changed too.

Jira issue

@Piedone Piedone added the enhancement New feature or request label Feb 22, 2022
Piedone referenced this issue in Lombiq/Orchard-Data-Tables May 12, 2022
@Piedone Piedone changed the title Use a version of CultureScope that doesn't have user overrides. Use a version of CultureScope that doesn't have user overrides Sep 18, 2022
@github-actions github-actions bot changed the title Use a version of CultureScope that doesn't have user overrides Use a version of CultureScope that doesn't have user overrides (OSOE-350) Sep 18, 2022
@Piedone
Copy link
Member

Piedone commented Oct 1, 2022

Once OrchardCMS/OrchardCore#12467 is merge, I think we can just update the _appsettings.json_s (the root ones) for our sites, and update the docs here to recommend that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants