OSOE-430: Improve stability directly after a page load #316
Conversation
| } | ||
| catch (StaleElementReferenceException) when (notLast) | ||
| { | ||
| Task.Delay(TimeSpan.FromSeconds(1)).Wait(); |
There was a problem hiding this comment.
Why not Thread.Sleep(TimeSpan.FromSeconds(1));?
| } | ||
| catch (StaleElementReferenceException) when (notLast) | ||
| { | ||
| Task.Delay(TimeSpan.FromSeconds(1)).Wait(); |
There was a problem hiding this comment.
Why not Thread.Sleep(TimeSpan.FromSeconds(1));?
| { | ||
| Task.Delay(TimeSpan.FromSeconds(1)).Wait(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not throw new InvalidOperationException("Impossible to reach."); here? Like below.
There was a problem hiding this comment.
As the text says, that's impossible to reach. The other methods need it because they expect to return a value so if I don't throw at the end then I get a compile time error even though it's really not a possible execution path.
| } | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Impossible to reach."); |
There was a problem hiding this comment.
A custom exception would be better or a constant for the message at least.
There was a problem hiding this comment.
That would be an unreasonable effort for a theoretically impossible scenario.
OSOE-430