-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDEAL-23: Updating visual verification documentation #335
Conversation
WalkthroughThe updates involve guidance on maintaining visual testing accuracy. A comment has been added to remind developers to update baseline images after altering UI elements. Additionally, the exception handling for missing baseline images in visual tests has been improved by suggesting a configuration change to disable retries when generating new baseline images. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs (1 hunks)
- Lombiq.Tests.UI/Exceptions/VisualVerificationBaselineImageNotFoundException.cs (1 hunks)
Files skipped from review due to trivial changes (1)
- Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs
Additional comments: 1
Lombiq.Tests.UI/Exceptions/VisualVerificationBaselineImageNotFoundException.cs (1)
- 22-25: The updated exception message provides clear instructions based on the
maxRetryCount
value. WhenmaxRetryCount
is not 0, it now advises setting it to 0 to generate images, which aligns with the PR objectives to improve exception handling for visual verification. This change should help developers understand the necessary steps when a baseline image is not found.
Beautiful! The "walkthrough" is longer than the actual documentation added. |
TDEAL-23