Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-807: Removing unneeded MultipleActiveResultSets=True config from the default SQL Server connection string #344

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Feb 12, 2024

OSOE-807
Fixes #343

Copy link
Contributor

coderabbitai bot commented Feb 12, 2024

Walkthrough

Walkthrough

The adjustments involve modifying the SQL Server connection configuration within a testing framework. Specifically, the MultipleActiveResultSets parameter is removed from the connection string template, and the TrustServerCertificate setting is altered to enforce a secure connection by default. This change is reflected in both a JSON configuration object and a corresponding C# class, ensuring consistency across the application's database management settings.

Changes

File(s) Change Summary
.../Configuration.md, .../SqlServerManager.cs Removed MultipleActiveResultSets from the connection string template and changed TrustServerCertificate to true in the JSON object. In the C# class, updated TrustServerCertificate from true to True.

Assessment against linked issues

Objective Addressed Explanation
Remove MultipleActiveResultSets=True (OSOE-807)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot changed the title Removing unneeded MultipleActiveResultSets=True config from the default SQL Server connection string OSOE-807: Removing unneeded MultipleActiveResultSets=True config from the default SQL Server connection string Feb 12, 2024
@sarahelsaig sarahelsaig merged commit 9c83e88 into dev Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MultipleActiveResultSets=True (OSOE-807)
2 participants