Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WALMA-144: Fixing PermissionExistsAsync parallelization problem #357

Merged
merged 9 commits into from
Apr 27, 2024
Merged

WALMA-144: Fixing PermissionExistsAsync parallelization problem #357

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8ea9db
Fixing UI testing problem
DemeSzabolcs Apr 25, 2024
85dcea7
Trying to fix NuGet publish
DemeSzabolcs Apr 25, 2024
e447d19
Fixing branch name
DemeSzabolcs Apr 25, 2024
3793829
Reverting
DemeSzabolcs Apr 25, 2024
9d864a9
Workaround
DemeSzabolcs Apr 25, 2024
53b3270
Revert "Workaround"
DemeSzabolcs Apr 25, 2024
588e8de
Update Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs
DemeSzabolcs Apr 26, 2024
ee6a90a
Trying Edge for tests
DemeSzabolcs Apr 27, 2024
b2110c9
Revert "Trying Edge for tests"
DemeSzabolcs Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Lombiq.Tests.UI/Extensions/ShortcutsUITestContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,10 +646,18 @@ private static bool IsAdminTheme(IManifestInfo manifest) =>
manifest.Tags.Any(tag => tag.EqualsOrdinalIgnoreCase(value: ManifestConstants.AdminTag));

private static async Task<bool> PermissionExistsAsync(
IEnumerable<IPermissionProvider> permissionProviders, string permissionName) =>
(await Task.WhenAll(permissionProviders.Select(provider => provider.GetPermissionsAsync())))
.SelectMany(permissions => permissions)
.Any(permission => permission.Name == permissionName);
IEnumerable<IPermissionProvider> permissionProviders, string permissionName)
DemeSzabolcs marked this conversation as resolved.
Show resolved Hide resolved
{
var permissions = permissionProviders.ToAsyncEnumerable();
await foreach (var provider in permissions)
{
var providerPermissions = await provider.GetPermissionsAsync();
if (providerPermissions.Any(permission => permission.Name == permissionName))
return true;
}

return false;
}

private static Task UsingScopeAsync(
UITestContext context,
Expand Down