Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMBQ-373: Fix visual verification tests instead of using Firefox and skipping them #392

Merged
merged 11 commits into from
Jul 21, 2024

Conversation

DemeSzabolcs
Copy link
Member

@DemeSzabolcs DemeSzabolcs commented Jul 19, 2024

throw new TimeoutException($"The time allotted for the test ({timeout}) was exceeded.");
throw new TimeoutException($"The time allowed for the test ({timeout}) was exceeded.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change. The phrase "the time allotted" is grammatically correct and appropriate for this specific context.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry 😅

@sarahelsaig sarahelsaig merged commit beb4746 into dev Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants