Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFFI-101: Frontend server support and interactive mode improvements #407

Merged
merged 40 commits into from
Sep 24, 2024
Merged

OFFI-101: Frontend server support and interactive mode improvements #407

merged 40 commits into from
Sep 24, 2024

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Sep 14, 2024 •
edited by jira bot
Loading

@sarahelsaig
Add ExecuteJavascriptTestAsync.
0b887d2
@sarahelsaig
Include the startup URL (for the port) in the BeforeAppStart event.
fb0b4d2
@sarahelsaig
Include port lease manager.
dd39189
@sarahelsaig
Add FrontendServer.
b981cf7
@sarahelsaig
Add optional func to check if the frontend server is ready.
3037450
@sarahelsaig
Add unified FrontendServer.Context to be used in the callbacks.
6c22fa2
@sarahelsaig
bug fix
808f234
@sarahelsaig
Code cleanup.
949b291
@sarahelsaig
Add and use WriteOutputTimestampedAndDebug.
6b4fb62
@sarahelsaig
Rewrite ExecuteJavascriptTestAsync to use node.
97cfe5a
@sarahelsaig
Send the host and port separately.
934b138
@sarahelsaig
Add missing thenAsync invocation.
752010a
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OFFI-101
56338bf
@sarahelsaig
Add and use GetText extension method.
86ab989
@sarahelsaig
Fix duplicate WithStandardOutputPipe.
652ae2e
@sarahelsaig
Add inspect switch.
a1a7f66
@sarahelsaig
Add ButtonText and use ByHelper where possible.
6e00d75
@sarahelsaig
Fix interactive mode.
0468f9e
@sarahelsaig
Add notification support for interactive mode.
90083b9
@sarahelsaig
Add GetDriverRemoteUri.
3282c20
@sarahelsaig
Code cleanup.
211bc78
@sarahelsaig
Use InvokeFuncAsync.
93e3f04
@sarahelsaig
Display missing error body.
3905bea
@sarahelsaig
Handle danging IDisposable that caused memory leak.
80f50c2
@sarahelsaig
Even better error reporting in CreateAndAuthorizeClientAsync.
5667426
@sarahelsaig
Fix unused argument.
bd4ca08
@sarahelsaig
Add skip condition.
9c4715b
@sarahelsaig
Add startupTimeout option.
03a5bf7
@sarahelsaig
Throw on timeout.
4a58ae7
@sarahelsaig
Remove unused method.
68e5158
wAsnk
wAsnk requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@wAsnk wAsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be documented in the Readme that it is now possible to do such thing like frontend UI testing. Please document it.

@sarahelsaig
Copy link
Member Author

sarahelsaig commented Sep 23, 2024 •
edited
Loading

Instead, I think a sample should be created in a separate future OSOCE issue. Because just documenting that it's possible is not that useful since it's not a trivial process.

@sarahelsaig sarahelsaig mentioned this pull request Sep 23, 2024
Closed
@wAsnk wAsnk merged commit 8ebbebf into dev Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wAsnk wAsnk wAsnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahelsaig @wAsnk