Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Best Practices #102

Merged
merged 4 commits into from
Feb 21, 2024
Merged

feat: Best Practices #102

merged 4 commits into from
Feb 21, 2024

Conversation

doprz
Copy link
Collaborator

@doprz doprz commented Feb 21, 2024

PR Notes

  • Add Vitest + tests for utils
  • Add eslint-plugin-simple-import-sort
  • Add package.json scripts for Prettier and ESLint
  • Add ESLint error for TSEnumDeclaration and refactor existing enums to as const objects
  • Add new GitHub workflows for tests, linting, and formatting

ESLint

        "no-restricted-syntax": [
            "error",
            "ForInStatement",
            "LabeledStatement",
            "WithStatement",
            {
                "selector": "TSEnumDeclaration",
                "message": "Don't declare enums",
            },
        ],
        "@typescript-eslint/consistent-type-exports": "error",
        "@typescript-eslint/consistent-type-imports": "error",
        "simple-import-sort/imports": "error",
        "simple-import-sort/exports": "error",

@doprz doprz requested review from sghsri and Razboy20 February 21, 2024 14:31
@doprz doprz self-assigned this Feb 21, 2024
@doprz doprz changed the base branch from main to hackathon February 21, 2024 14:32
@doprz doprz force-pushed the feature/best-practices branch from c7ffe0a to aed0a14 Compare February 21, 2024 19:41
@doprz doprz merged commit d5a04c7 into hackathon Feb 21, 2024
1 of 9 checks passed
@doprz doprz deleted the feature/best-practices branch February 21, 2024 21:54
doprz added a commit that referenced this pull request Mar 6, 2024
* feat: best practices

* feat: add tests workflow

* feat: add best-practices workflow

* fix: wrong indentation in workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants