feat: fix icons on PopupMain and convert to tailwind #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razboy20
previously requested changes
Feb 25, 2024
src/views/components/PopupMain.tsx
Outdated
| @@ -50,7 +53,7 @@ export default function PopupMain() { | |||
| style={{ backgroundColor: '#bf5700', borderRadius: '8px', padding: '8px' }} | |||
| onClick={handleOpenCalendar} | |||
| > | |||
| <FaCalendarAlt color='white' /> | |||
| <CalendarIcon color='white' /> | |||
There was a problem hiding this comment.
Replace color= prop with className="text-white"
src/views/components/PopupMain.tsx
Outdated
| @@ -62,7 +65,7 @@ export default function PopupMain() { | |||
| }} | |||
| onClick={handleOpenOptions} | |||
| > | |||
| <FaCog color='#C05621' /> | |||
| <SettingsIcon color='#C05621' /> | |||
There was a problem hiding this comment.
Replace the color prop here as well with a text- class, however what is the color supposed to be? Let's replace this with the propor theme color.
doprz
requested changes
Feb 25, 2024
src/views/components/PopupMain.tsx
Outdated
| @@ -10,9 +10,12 @@ import { handleOpenCalendar } from '@views/components/injected/CourseCatalogInje | |||
| import useSchedules from '@views/hooks/useSchedules'; | |||
| import { openTabFromContentScript } from '@views/lib/openNewTabFromContentScript'; | |||
| import React from 'react'; | |||
| import { FaCalendarAlt, FaCog, FaRedo } from 'react-icons/fa'; // Added FaRedo for the refresh icon | |||
| import { TestColors } from 'src/stories/components/PopupCourseBlock.stories'; | |||
There was a problem hiding this comment.
It's not a good practice to import things from Storybook files. I would recommend extracting this as a common resource.
src/views/components/PopupMain.tsx
Outdated
| @@ -50,7 +53,7 @@ export default function PopupMain() { | |||
| style={{ backgroundColor: '#bf5700', borderRadius: '8px', padding: '8px' }} | |||
DhruvArora-03
changed the title
doprz
requested changes
Feb 25, 2024
doprz
requested changes
Feb 25, 2024
doprz
approved these changes
Feb 26, 2024
doprz
dismissed
Razboy20’s stale review
Requested PR changes were addressed.
doprz
added a commit
that referenced
this pull request
Mar 6, 2024
* feat: fix icons on PopupMain * fix: use text-white * fix: move TestColors * fix: convert to tailwind * fix: finish moving TestColors out * chore: add path alias * chore: lint PR * feat: create storybook.ts and move tailwindColorways there --------- Co-authored-by: doprz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switched to using material symbol icons
the old version relied on Fa icons that we no longer use, so I replaced it with references to our material symbol icons
also went ahead and converted styling to tailwind