feat: color palette for calendar #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavchadaga
commented
Mar 1, 2024
src/views/components/common/CourseCellColorPicker/CourseCellColorPicker.tsx
Show resolved
Hide resolved
abhinavchadaga
commented
Mar 1, 2024
doprz
reviewed
Mar 1, 2024
Comment on lines
35
to
39
| if (isSelected) { | ||
| handleSetSelectedColorPatch(-1); | ||
| } else { | ||
| handleSetSelectedColorPatch(index); | ||
| } |
There was a problem hiding this comment.
This works but you can also make this a one-liner just for fun.
Suggested change
| if (isSelected) { | |
| handleSetSelectedColorPatch(-1); | |
| } else { | |
| handleSetSelectedColorPatch(index); | |
| } | |
| handleSetSelectedColorPatch(isSelected ? -1 : index); |
doprz
reviewed
Mar 1, 2024
src/views/components/common/CourseCellColorPicker/CourseCellColorPicker.tsx
Show resolved
Hide resolved
doprz
reviewed
Mar 1, 2024
doprz
reviewed
Mar 4, 2024
doprz
reviewed
Mar 4, 2024
Comment on lines
35
to
39
| if (isSelected) { | ||
| handleSetSelectedColorPatch(-1); | ||
| } else { | ||
| handleSetSelectedColorPatch(index); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isSelected) { | |
| handleSetSelectedColorPatch(-1); | |
| } else { | |
| handleSetSelectedColorPatch(index); | |
| } | |
| handleSetSelectedColorPatch(isSelected ? -1 : index); |
doprz
approved these changes
Mar 4, 2024
|
Approved. Will resolve some of these comments in the |
doprz
added a commit
that referenced
this pull request
Mar 6, 2024
* feat: work on the palette * feat: palette basically done? * fix: lint warnings and errors * fix: minor fixes * fix: color patch colors and shades * fix: prettier issue * chore: use TS satisfies * chore: remove eslint-disable comment --------- Co-authored-by: doprz <[email protected]>
Razboy20
added a commit
that referenced
this pull request
Mar 8, 2024
Razboy20
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the color picker component for the calendar view that allows users to set custom colors for their course schedules.
BASIC DEMO
SELECTING SHADES
Using Custom Colors
I let copilot pick the hue shades since I was lazy - will fix that [EDIT: fixed in code, just not in the gifs above]