feat: open an injected course page on course block click in popup main #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich may or may not open the calendar
… and i think popupmain opens calendar now when the course block is clicked
…calendar using urlsearchparams
|
Quick explanation of what is basically left: When calendar.tsx detects a course it (should) open up the course injected popup, so the course just needs to be made on calendar.tsx. The parameter passing is set up now |
|
(fixing tests real quick ignore that) |
doprz
changed the title
doprz
requested changes
Mar 16, 2024
Razboy20
requested changes
Mar 16, 2024
src/views/components/common/PopupCourseBlock/PopupCourseBlock.tsx
Outdated
Show resolved
Hide resolved
Razboy20
requested changes
Mar 16, 2024
src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/PopupCourseBlock/PopupCourseBlock.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/PopupCourseBlock/PopupCourseBlock.tsx
Outdated
Show resolved
Hide resolved
Razboy20
approved these changes
Mar 16, 2024
|
WE DID IT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't got any courses to show, but this is a description:
(fig 1.)
When we click on a course here, we want to open up calendar, and open up the associated injected popup for that course, shown in fig 2
(fig 2.)
Current implementation is as such:
PopupCourseBlock takes in a function for clicking functionality, defaulting to nothing if we want nothing to happen. I found active schedule in popupmain, so I attached the handleOpenCalendar function to those course block components.
handleOpenCalendar takes in two parameters at the moment, the uniqueId and the associated course.
From there, the intention is to open calendar with parameters. I believe they pass correctly, but right now I'm only passing the uniqueId because I'm not sure what to do with the course.
From the calendar's side, I use URLSearchParams to receive the params (currently only uniqueId)
I saw some work in progress code on calendar so wasn't sure what to do with that. That's where we are for now! Lemme know your thoughts
edit: Looks like we're good to go now!