Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abhinavchadaga/reusable-popup-prompt #148

Merged

Conversation

abhinavchadaga
Copy link
Contributor

@abhinavchadaga abhinavchadaga commented Mar 12, 2024

Reusable popup prompt that takes a title, description, and button children components. Uses headless UI's Transition and Dialog components for accessibility and interactivity. Handles clicks outside the prompt, escape key, etc.

DEMO
demo

@abhinavchadaga abhinavchadaga marked this pull request as ready for review March 12, 2024 00:51
@doprz doprz self-requested a review March 12, 2024 04:35
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! I left some small comments but overall it looks clean, organized, and well formatted.

src/stories/components/Prompt.stories.tsx Outdated Show resolved Hide resolved
src/views/components/common/Prompt/Prompt.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@sghsri sghsri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the Storybook!

src/views/components/common/Prompt/Prompt.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved!

@doprz doprz merged commit 44af9e1 into Longhorn-Developers:main Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants