Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed bug where activeSchedule doesn't update correctly #158

Merged
merged 3 commits into from
Mar 14, 2024
Merged

fix: fixed bug where activeSchedule doesn't update correctly #158

merged 3 commits into from
Mar 14, 2024

Conversation

knownotunknown
Copy link
Contributor

Fixed a bug that happened on my end. But in general, probably better to have these safeguards in place to make sure we're always returning a valid activeSchedule.

@doprz doprz self-requested a review March 14, 2024 02:07
doprz
doprz requested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, all I have is a small question.

src/views/hooks/useSchedules.ts Show resolved Hide resolved
doprz
doprz approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this for now but I do want to revisit how we approach this instead of passing an error message as a schedule.

@knownotunknown knownotunknown merged commit a409090 into Longhorn-Developers:main Mar 14, 2024
6 checks passed
@knownotunknown knownotunknown deleted the activeIndex-safety-rails branch March 14, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knownotunknown @doprz