feat: add new db powered by UT_Grade_Parser

[doprz]

This change is 

[Samathingamajig]

something is wrong with the db, reviewing UT_Grade_Parser

[doprz]

PR blocked until UT_Grade_Parser bug is resolved.

[Razboy20]

Reviewed 2 of 4 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @doprz and @Samathingamajig)

---

src/views/components/injected/CourseCatalogInjectedPopup/GradeDistribution.tsx line 0 at r2 (raw file):
Let's use imports rather than use React.

Code snippet:

React.useMemo -> useMemo
React.useState -> useState

---

src/views/lib/database/queryDistribution.ts line 11 at r2 (raw file):

    'grade_distributions_2021_2022',
    'grade_distributions_2022_2023',
] as const;

fyi, in the future let's maybe refactor this to be reactive to the items in the db rather than being explicit.

Code quote:

const allTables = [
    'grade_distributions_2019_2020',
    'grade_distributions_2020_2021',
    'grade_distributions_2021_2022',
    'grade_distributions_2022_2023',
] as const;

---

src/views/lib/database/queryDistribution.ts line 99 at r2 (raw file):

        where Department_Code = '${course.department}'
        and Course_Number = '${course.number}'
        ${semester ? `and Semester = '${semester.season} ${semester.year}'` : ''}

Can we sanitize this more? I noticed that the previous revision used %% wrappings, idk whether this is something we should add or not.

Code quote:

    const query = `
        select * from ${semester ? `grade_distributions_${semester.year + yearDelta}_${semester.year + yearDelta + 1}` : `(select * from ${allTables.join(' union all select * from ')})`}
        where Department_Code = '${course.department}'
        and Course_Number = '${course.number}'
        ${semester ? `and Semester = '${semester.season} ${semester.year}'` : ''}

---

src/views/lib/database/queryDistribution.ts line 139 at r2 (raw file):

        F: row.F,
        Other: row.Other,
    } satisfies Distribution;

Why satisfies? By virtue of having a return type, ts knows the type of the object.

[Samathingamajig]

Reviewed 2 of 3 files at r3, all commit messages.
Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @doprz and @Razboy20)

---

src/views/lib/database/queryDistribution.ts line 11 at r2 (raw file):

Previously, Razboy20 wrote…

fyi, in the future let's maybe refactor this to be reactive to the items in the db rather than being explicit.

yeah... I wanted to do that, but also didn't want to get every table name in case there are more in the future that aren't grade distributions (could've filtered by grade_distributions_\d+_\d+ but who cares)

---

src/views/lib/database/queryDistribution.ts line 99 at r2 (raw file):

Previously, Razboy20 wrote…

Can we sanitize this more? I noticed that the previous revision used %% wrappings, idk whether this is something we should add or not.

the %% wrapping wasn't sanitization, they're wildcards. it was something like Course_Number like '%314%' which would match "314H" (314 honors).

As for preventing SQL injections, 1. this is running completely locally, 2. I don't think there will ever be a department id, course id, or semester (e.g. "Summer 2022") with an apostrophe, but I do agree we should probably use a sanitizer just in case (especially if a field is ever added where that could be a problem) and to make cleaner code.

[Razboy20]

Reviewed 1 of 3 files at r3, all commit messages.
Dismissed @Razboy20 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @doprz)

---

src/views/lib/database/queryDistribution.ts line 99 at r2 (raw file):

Previously, Samathingamajig (Samuel Gunter) wrote…

the %% wrapping wasn't sanitization, they're wildcards. it was something like Course_Number like '%314%' which would match "314H" (314 honors).

As for preventing SQL injections, 1. this is running completely locally, 2. I don't think there will ever be a department id, course id, or semester (e.g. "Summer 2022") with an apostrophe, but I do agree we should probably use a sanitizer just in case (especially if a field is ever added where that could be a problem) and to make cleaner code.

Yeah I agree, sanitization is not a real concern, but just for posterity.