Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use downloadBlob util #186

Merged
merged 7 commits into from
Mar 21, 2024
Merged

feat: use downloadBlob util #186

merged 7 commits into from
Mar 21, 2024

Conversation

doprz
Copy link
Collaborator

@doprz doprz commented Mar 21, 2024

This change is Reviewable

src/shared/util/downloadBlob.ts Outdated Show resolved Hide resolved
src/views/components/calendar/utils.ts Outdated Show resolved Hide resolved
@doprz doprz requested a review from Samathingamajig March 21, 2024 21:08
Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @doprz and @Samathingamajig)

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doprz doprz merged commit 2dfb10e into main Mar 21, 2024
11 of 12 checks passed
@doprz doprz deleted the feature/downloadBlob-util branch March 21, 2024 21:25
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
* feat: use downloadBlob util

* chore: lint

* fix: revert saveCalAsPng

* feat: refactor downloadBlob

* chore: remove comments

* chore: lint and remove extra async

* refactor: cleanup

---------

Co-authored-by: Razboy20 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants