Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DialogProvider component #198

Merged
merged 5 commits into from
May 20, 2024
Merged

feat: DialogProvider component #198

merged 5 commits into from
May 20, 2024

Conversation

Samathingamajig
Copy link
Collaborator

@Samathingamajig Samathingamajig commented Mar 24, 2024 •
edited by Razboy20
Loading

This change is Reviewable

Samathingamajig and others added 2 commits March 24, 2024 02:33
@Samathingamajig
feat: somewhat working DialogProvider
42f99a8
@Samathingamajig @Razboy20
feat: handle multiple dialogs properly, initial focus
76220fc 
let's just ignore that showFocus=true doesn't work with "nested" dialogs

Co-authored-by: Razboy20 <[email protected]>
@Razboy20 Razboy20 marked this pull request as ready for review May 10, 2024 00:27
IsaDavRod
IsaDavRod previously requested changes May 19, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment •
edited by Razboy20
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The heading should be UTRP Black (#1A2024). Right now it is #303030
  • The body text should be Black (#333F48) (UT version or whatever)
  • Row gap between header and body text should be .625 rem.
  • Row gap between the body text and the button should be .8125 rem.
Screenshot 2024-05-19 at 10 56 53 AM

Razboy20
Razboy20 approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Samathingamajig)

@Razboy20 Razboy20 requested a review from IsaDavRod May 19, 2024 23:23
@Razboy20 Razboy20 self-assigned this May 19, 2024
@Razboy20 Razboy20 merged commit d1b921a into Longhorn-Developers:main May 20, 2024
7 checks passed
@Samathingamajig Samathingamajig deleted the sgunter/feat-dialog-provider branch May 21, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razboy20 Razboy20 Razboy20 approved these changes

@IsaDavRod IsaDavRod Awaiting requested review from IsaDavRod

Assignees
No one assigned
Labels
feature ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Samathingamajig @Razboy20 @IsaDavRod