-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove course name from the syllabi lookup #200
fix: remove course name from the syllabi lookup #200
Conversation
Do we want to include the instructor name in the lookup? |
I think it's not supposed to be professor specific, just course specific based |
Supposed to as in based on what Isaiah or someone else said in the past? Professors have different syllabi. |
Maybe we should account for the instructor in the lookup. Take PED 106C Weight Training w RICH, GEOFF for example: Without accounting for the instructor, you just see all the courses and have too look for Geoff Rich. Including instructor will take you straight to Geoff Rich's syllabi. Some instructors have different syllabi. (And including instructor is consistent with the way RMP and CES buttons work (they take you to the instructor, not just the course)). |
I know its been a while but do we have a resolution for this |
Account for the instructor |
src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but let's wait for all of us to agree on this PR as there were some initial discussions regarding how to proceed with this.
Remove the course name and add the instructor first and last name to the lookup. Opens a new tab for each instructor in the list of instructors.
Single professor
Multiple professors
This change is