Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove course name from the syllabi lookup #200

Conversation

abhinavchadaga
Copy link
Contributor

@abhinavchadaga abhinavchadaga commented Mar 25, 2024

Remove the course name and add the instructor first and last name to the lookup. Opens a new tab for each instructor in the list of instructors.

Single professor
single-professor

Multiple professors
multiple-professors


This change is Reviewable

@abhinavchadaga abhinavchadaga marked this pull request as ready for review March 25, 2024 19:10
@Razboy20
Copy link
Member

Do we want to include the instructor name in the lookup?

@abhinavchadaga
Copy link
Contributor Author

abhinavchadaga commented Mar 25, 2024

Do we want to include the instructor name in the lookup?

I think it's not supposed to be professor specific, just course specific based

@knownotunknown
Copy link
Contributor

Do we want to include the instructor name in the lookup?

I think it's not supposed to be professor specific, just course specific based

Supposed to as in based on what Isaiah or someone else said in the past? Professors have different syllabi.

@IsaDavRod
Copy link
Member

IsaDavRod commented Mar 25, 2024

Do we want to include the instructor name in the lookup?

I think it's not supposed to be professor specific, just course specific based

Supposed to as in based on what Isaiah or someone else said in the past? Professors have different syllabi.

Maybe we should account for the instructor in the lookup. Take PED 106C Weight Training w RICH, GEOFF for example: Without accounting for the instructor, you just see all the courses and have too look for Geoff Rich. Including instructor will take you straight to Geoff Rich's syllabi. Some instructors have different syllabi. (And including instructor is consistent with the way RMP and CES buttons work (they take you to the instructor, not just the course)).

@abhinavchadaga
Copy link
Contributor Author

I know its been a while but do we have a resolution for this

@IsaDavRod
Copy link
Member

Account for the instructor

@abhinavchadaga abhinavchadaga requested review from doprz, knownotunknown and Razboy20 and removed request for doprz and knownotunknown April 8, 2024 05:45
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's wait for all of us to agree on this PR as there were some initial discussions regarding how to proceed with this.

@doprz doprz merged commit bcb5a8c into Longhorn-Developers:main Apr 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants