Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added room number to course popup #231

Merged

Conversation

vinsonzheng499
Copy link
Contributor

@vinsonzheng499 vinsonzheng499 commented Sep 29, 2024

Added room number to injected course popup

Screenshot

This change is Reviewable


This change is Reviewable

@vinsonzheng499 vinsonzheng499 self-assigned this Sep 29, 2024
@DereC4 DereC4 requested a review from sghsri September 29, 2024 02:19
src/shared/types/CourseMeeting.ts Outdated Show resolved Hide resolved
@Razboy20 Razboy20 added ready-for-review awaiting-changes UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap labels Sep 29, 2024
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinsonzheng499 vinsonzheng499 force-pushed the vinson/add-popup-room-number branch 3 times, most recently from 4581dc1 to a47e805 Compare September 29, 2024 21:02
@vinsonzheng499 vinsonzheng499 force-pushed the vinson/add-popup-room-number branch from a47e805 to dac3199 Compare September 30, 2024 04:32
@IsaDavRod IsaDavRod requested a review from Razboy20 September 30, 2024 14:15
@Razboy20 Razboy20 merged commit 9eaff24 into Longhorn-Developers:main Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes bugfix ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants