Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental toggle for icons, left off for now #237

Merged
merged 10 commits into from
Sep 29, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Sep 29, 2024

icon toggle that is false for now as requested


This change is Reviewable

@DereC4
Copy link
Member Author

DereC4 commented Sep 29, 2024

image

@DereC4
Copy link
Member Author

DereC4 commented Sep 29, 2024

and more

@DereC4 DereC4 requested a review from doprz September 29, 2024 10:34
src/shared/util/experimental.ts Outdated Show resolved Hide resolved
src/shared/util/experimental.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Razboy20 with his PR review comments, other than that this PR looks good. Awaiting changes and then we'll review once again.

@DereC4 DereC4 requested review from doprz and Razboy20 September 29, 2024 19:58
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz dismissed Razboy20’s stale review September 29, 2024 20:11

Dismissing as new changes fix previously requested changes.

@doprz doprz merged commit f34dd95 into Longhorn-Developers:main Sep 29, 2024
6 checks passed
@DereC4
Copy link
Member Author

DereC4 commented Sep 29, 2024

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants