Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newer grades and parameterized queries #238

Conversation

Samathingamajig
Copy link
Collaborator

@Samathingamajig Samathingamajig commented Sep 30, 2024

previously, we were using template strings, which had issues for professors with an apostrophe in their name

now includes data up to Spring 2024 (of whatever classes have public data for Spring 2024 now)

now:
image

previously:
image


This change is Reviewable

previously, we were using template strings,
which had issues for professors with an apostrophe in their name
@doprz doprz self-requested a review September 30, 2024 02:13
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit 75ad416 into Longhorn-Developers:main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants