Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visual overflow bug when editing schedule name #251

Merged

Conversation

EthanL06
Copy link
Contributor

@EthanL06 EthanL06 commented Oct 1, 2024

#250

image

Radio button no longer squished when editing


This change is Reviewable

@DereC4 DereC4 requested a review from Razboy20 October 2, 2024 01:22
@doprz doprz self-requested a review October 2, 2024 03:12
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz
Copy link
Collaborator

doprz commented Oct 2, 2024

I'll wait for @Razboy20 's review for this PR as some further developments are being discussed.

@EthanL06
Copy link
Contributor Author

EthanL06 commented Oct 2, 2024

image
The latest change with the dynamic width is still causing this overflow visual bug. Still looking into it

doprz
doprz previously requested changes Oct 2, 2024
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @EthanL06 for the overflow visual bug.

@doprz doprz changed the title fix: visual bug when editing schedule name fix: visual overflow bug when editing schedule name Oct 2, 2024
@EthanL06
Copy link
Contributor Author

EthanL06 commented Oct 2, 2024

Hopefully this last change will do it lol

@Razboy20 Razboy20 dismissed doprz’s stale review October 2, 2024 04:08

solved issue

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after new changes were applied after last review

@Razboy20 Razboy20 merged commit e8d2c2e into Longhorn-Developers:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants