Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report issue popup #261

Merged
merged 8 commits into from
Oct 13, 2024
Merged

feat: report issue popup #261

merged 8 commits into from
Oct 13, 2024

Conversation

sghsri
Copy link
Collaborator

@sghsri sghsri commented Oct 4, 2024

This pull request introduces several new features and improvements, including the addition of a feedback reporting system, enhancements to the schedule creation logic, and various UI adjustments. Below is a summary of the most important changes:

New Features:

  • Feedback Reporting System:
    • Added @sentry/react dependency to package.json for error and feedback reporting. (package.json)
    • Created a new ReportIssueMain component to handle user feedback submission. (src/views/components/ReportIssueMain.tsx)
    • Implemented the openReportWindow function to open a centered report window. (src/shared/util/openReportWindow.ts)
    • Added a button in the popup to open the report window. (src/views/components/PopupMain.tsx)

Enhancements:

  • Schedule Creation Logic:
    • Improved createSchedule function to prevent duplicate schedule names by appending a number if necessary. (src/pages/background/lib/createSchedule.ts)

UI Adjustments:

  • Popup Window Size:
    • Adjusted the popup window dimensions for better usability. (src/pages/popup/index.html)

Codebase Simplification:

  • Removed Unused Imports and Functions:
    • Cleaned up unused imports and functions across various files. (src/views/components/calendar/CalenderHeader.tsx, src/views/lib/openNewTabFromContentScript.ts) [1] [2]

Configuration Updates:

  • Vite Configuration:
    • Updated vite.config.ts to include the new report page. (vite.config.ts) [1] [2] [3]

This change is Reviewable

@doprz doprz requested review from doprz and Razboy20 October 4, 2024 16:14
@doprz doprz added the utrp-v2 label Oct 4, 2024
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the feedback button, should we also add a feedback link in the Calendar view's "From the Team" section as seen below?

image

@doprz
Copy link
Collaborator

doprz commented Oct 6, 2024

For the feedback button, should we also add a feedback link in the Calendar view's "From the Team" section as seen below?

image

I think that's a good idea, let's apply that in a new PR.

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts with this PR

@doprz doprz requested review from IsaDavRod and doprz October 11, 2024 18:49
src/pages/popup/index.html Outdated Show resolved Hide resolved
@doprz doprz requested a review from IsaDavRod October 12, 2024 23:51
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit 65ff6bf into main Oct 13, 2024
11 checks passed
@doprz doprz deleted the bunch-of-small-fixes branch October 13, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants