-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release notes #283
feat: release notes #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, like how it looks! Couple changes in addition to the comments left in the code:
- Features should be placed before Bug fixes.
- Each commit/PR should also include the author. Perhaps should be limited to only PR contributions? Open to discussion.
- Style wise, header could probably be a bit larger, and there is too much padding at the top. Also, maybe we might want to use *color* but not sure.
I'm using angular as the preset but I can also use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better!
Couple things:
- Could you add a "Ok" button in orange
- Have the 2.0.0-beta4 changelog title render as an actual dialog title rather than as part of the description. Not sure what the best way to do this is as it's included in the markdown; if not easily possible, style the h1 to match the default dialog title styling.
- Double check that text stylings match component styles.
- close button to the top right? (I don't recall whether we have a good method for the close button right now, so you can decide against this)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LDTM
Fixed changes requested in review and approved by Sam
oh FINALLY |
Features
PatchNotesPopup.tsx
with GFM rendering + respective storybook fileChore
This change is