Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate schedule name regex no longer grabs trailing white space #286

Merged

Conversation

caseycharleston
Copy link
Contributor

@caseycharleston caseycharleston commented Oct 8, 2024

  • fix: Duplicating a schedule no longer grabs trailing spaces between a given name and its duplicate counter. trim() is applied to any valid regex matching for baseName

Normal schedule name:
image

Schedule name with extra space:
image

To reproduce this with the current build, do the following:

  1. Create 3 new schedules (New Schedule, New Schedule (1), New Schedule (2) )
  2. Duplicate New Schedule (1)
  3. This should create a schedule called New Schedule (2) but appear like New Schedule (2) in the list, unless editing its name

This change is Reviewable


This change is Reviewable

@Razboy20 Razboy20 added the bugfix label Oct 8, 2024
@caseycharleston caseycharleston marked this pull request as ready for review October 8, 2024 16:13
@caseycharleston caseycharleston self-assigned this Oct 8, 2024
@Razboy20 Razboy20 merged commit d73615e into Longhorn-Developers:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants