Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migration update showing #293

Merged
merged 9 commits into from
Oct 12, 2024
Merged

feat: migration update showing #293

merged 9 commits into from
Oct 12, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Oct 12, 2024 •
edited by doprz
Loading

derek's part to be connected to Diego's PR #292

image

Huly®: UTRP-290

This change is Reviewable

@DereC4 DereC4 marked this pull request as draft October 12, 2024 05:22
@DereC4 DereC4 self-assigned this Oct 12, 2024
@doprz doprz self-requested a review October 12, 2024 05:28
doprz
doprz requested changes Oct 12, 2024
View reviewed changes
src/views/components/common/UpdateText.tsx Outdated Show resolved Hide resolved
@DereC4 DereC4 marked this pull request as ready for review October 12, 2024 05:47
@DereC4 DereC4 requested a review from doprz October 12, 2024 05:48
IsaDavRod
IsaDavRod requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make these three style changes:
image

doprz
doprz requested changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that all of the checks are passing.

IsaDavRod
IsaDavRod approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component style LGTM

doprz
doprz approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit aede681 into Longhorn-Developers:main Oct 12, 2024
6 checks passed
@DereC4
Copy link
Member Author

DereC4 commented Oct 12, 2024

OH FINALLY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

@IsaDavRod IsaDavRod IsaDavRod approved these changes

Assignees

@DereC4 DereC4

Labels
feature utrp-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DereC4 @IsaDavRod @doprz