feat: add core curriculum chips to injected popup

[tildezero]

resolves #337

image:

_{Huly®: UTRP-356}

---

This change is 

[IsaDavRod]

Doesn't look like it works for courses with the Mathematics or Visual and Performing Arts core. Also, can you see if the text can be more centered somehow (see second pic to see what I mean)? It looks a bit off (looks like N1 is aligned left or something)

[DereC4]

not me literally downloading chrome in order to test this branch 😭😭

for ID chip

english composition chip

humanities chip

gov chip

history chip

SB chip

math chip

n1 chip

n2 chip

VAPA chip

[IsaDavRod]

Two things need fixing:
1: The gap between flag chips and core chips is too big (should be the same value as the gap between two flag chips)
2: It appears that the core chips looks like it has a bigger gap with the course instructor name whereas flag chips don't have an unusually bigger gap.

Also, not sure why, but I had to manually re-add my saved calendar courses from the course schedule to get the flag chip to appear. If the extension were to update, peeps who have an existing schedule wouldn't be able to see core chips unless they re-added the course from the course schedule page.

Two flags (correct gaps)

One core (w usually large gap w the instructor name)

One flag, one core (w usually large gap between each other)

[Samathingamajig]

Also, not sure why, but I had to manually re-add my saved calendar courses from the course schedule to get the flag chip to appear. If the extension were to update, peeps who have an existing schedule wouldn't be able to see core chips unless they re-added the course from the course schedule page.

that is acceptable behavior for now. In the future, we need a way to rescrape all the data when the extension updates (if we changed something about the Course schema or how data is scrapes), but that is complicated and out of scope for this PR. If you would like, we could block this PR on those other changes, but I don't think that's necessary.

[tildezero]

core chip only ^

flag + core ^

[Samathingamajig]

looking good, sorry for the longer review process but this change is significantly larger than most of the other "simple" tasks by its nature

just a few simplification comments to ensure consistent code quality

[Samathingamajig]

LGTM

[IsaDavRod]

LGTM yayy

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ TypeError: Cannot destructure property 'courseName' of 'kt' as it is null. HeadingAndActions(../../src/views/components/in... View Issue

_{Did you find this useful? React with a 👍 or 👎}