Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove screenshot padding class for png download for #344 #376

Conversation

Preston-Cook
Copy link
Contributor

@Preston-Cook Preston-Cook commented Oct 22, 2024

Removed padding screenshot class from calendar course cell to prevent cutoff issue for 1 hr courses

Huly®: UTRP-360


This change is Reviewable

@Samathingamajig
Copy link
Collaborator

can we see before/after screenshots please?

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaDavRod IsaDavRod requested a review from Razboy20 October 22, 2024 04:46
@Preston-Cook
Copy link
Contributor Author

Before:
before
After:
after

@Samathingamajig
Copy link
Collaborator

Another before/after on a different sized screen:

before:
my-calendar - 2024-10-22T000817 531

after:
my-calendar - 2024-10-22T000840 474

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your PR!

@Samathingamajig Samathingamajig merged commit 768ac77 into Longhorn-Developers:main Oct 22, 2024
20 checks passed
@IsaDavRod IsaDavRod linked an issue Oct 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix calendar Save as .PNG course block text chopping for 1hr courses.
3 participants