Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more relevant links to the From the Team section #380

Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat: add more relevant links to the From the Team section #380

merged 3 commits into from
Oct 22, 2024

Conversation

tonydnh
Copy link
Contributor

@tonydnh tonydnh commented Oct 22, 2024 •
edited by Razboy20
Loading

Resolves #354

Huly®: UTRP-365

This change is Reviewable

Samathingamajig
Samathingamajig approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's a weird thing that I'm not sure how to change (if it evens need changing), so I want to get another set of eyes on it

src/views/components/calendar/TeamLinks.tsx Outdated Show resolved Hide resolved
IsaDavRod
IsaDavRod approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links work (including opening feedback dialog yay). LGTM

doprz
doprz approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Samathingamajig
Samathingamajig approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig merged commit 643ea13 into Longhorn-Developers:main Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doprz doprz doprz approved these changes

@IsaDavRod IsaDavRod IsaDavRod approved these changes

@Samathingamajig Samathingamajig Samathingamajig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the "From the Team" section to include more relevant links
4 participants
@tonydnh @Samathingamajig @IsaDavRod @doprz