Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): calendar sidebar redesign #464

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

EthanL06
Copy link
Contributor

@EthanL06 EthanL06 commented Dec 23, 2024

#461

Sidebar Open:
Screenshot 2024-12-22 at 7 02 11 PM

Sidebar Closed:
Screenshot 2024-12-22 at 7 02 36 PM


This change is Reviewable

@EthanL06 EthanL06 changed the title feat: calendar sidebar redesign feat(ui): calendar sidebar redesign Dec 23, 2024
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The left and right padding for the calendar sidebar should be spacing-8 instead of 30px
  • The top and bottom padding for the calendar sidebar should be spacing-6 instead of 20px
  • Add a min-width: 20.3125rem; to the calendar sidebar
  • When the window width is small, the logo changes to icon only. Now that the logo is in the sidebar, always show the icon + text.
  • last min comment: When the window height is small, the position of the the scrollbar looks a bit funky. If anything, the Logo and Hamburger icon in the sidebar should be sticky just like the sidebar footer.

  • Change the MY SCHEDULES text, RESOURCES text, hamburger icon, and plus icon to UTRP (theme) black: #1A2024. Next, change the footer social icons and settings icon to UT Black: #333F48
  • Use spacing-7 to separate the calendar sidebar's header from the body/footer (in other words, between the logo and My Schedules section)
  • The dividers/borders separating each section in the calendar sidebar should no longer have a top or bottom margin. After that change, use spacing-6 to separate each section (since it would also apply to the modified dividers, it would add spacing-6 to the top and bottom of the divider)
  • image
  • Use spacing-3 gap to separate each section title from it's content (in other words, to separate RESOURCES from the links or MY SCHEDULES from the schedule list)

  • Use spacing-3 gap to separate each schedule in the schedule list under MY SCHEDULES (not sure if a component already exists for this list/each schedule. If so, just change it there)
  • Use spacing-3 gap to separate the drag icon from the radio button and schedule name for each schedule in the schedule list.

  • Use spacing-3 gap for the calendar sidebar's important links (also rename Important Links to Resource Links in the codebase)
  • Use spacing-2 gap to separate each resource link from the up-right-arrow icon

  • Use spacing-5 gap for the calendar sidebar's footer social icons

Copy link
Contributor Author

@EthanL06 EthanL06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a039ea9

This commit also addresses #285.

@EthanL06 EthanL06 requested a review from IsaDavRod December 28, 2024 06:57
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The social icons color is showing as #303030 and Im not sure why but its a color that has persisted in other areas (outside this PR) even though it is never used in any design. The social icons should be UT black (#333F48). Try finding why the #303030 color is overriding the UT black.

  • Ensure each schedule row is fixed at a height of 30px (or 1.88rem) and each schedule row is separated by spacing-3 (see image below for the Figma design)

(ignore the spacing2 in the image. It should be spacing-3)

image
  • I made an oopsie daisy on the drag indicators before the schedule names: In my figma, I had the width as 10px instead of 24px (which is the normal width for all icons). Drag indicators are an exception because I didn't want the extra space on the left of each drag indicator (it makes the schedule list look indented). Is it possible to try changing the width of the drag indicator so that it doesn't have extra empty space around the drag indicators? (if you see the image below, the drag indicator width should be like the purple rectangle, not the purple square since that adds extra space. The size of the icon should not change though, just the "boundaries" of the container the icon is in). After this, try comparing the PR with the Figma to see if padding is consistent and if it "looks" the same.
image

Another thing is the row gap between the logo and the social icons. It is too big of a gap because we are using two spacings instead of one. (I had to change the Figma slightly for this since it was an oversight)

  • For the logo + hamburger button "header" have a top and bottom padding of spacing-6, but no top padding above the MY SCHEDULES/body container. This will allow some padding to always show on the sticky header when the window height is small and the body container is scrollable. (see first and second images below)
  • For the footer, the purple area in the third image below is extra padding we do not need since we already have padding above the footer

Image 1: From Figma

(ignore the spacing5 in the image. It should be spacing-6)

image

Image 2: This is how it should look like when scroll is enabled because the window width is small (notice the gap between the body content and the header content)
image

Image 3: footer padding
image

@IsaDavRod IsaDavRod linked an issue Dec 31, 2024 that may be closed by this pull request
11 tasks
@IsaDavRod IsaDavRod changed the title feat(ui): calendar sidebar redesign feat(ui): calendar sidebar redesign and spacing system Dec 31, 2024
@EthanL06 EthanL06 closed this Jan 3, 2025
@EthanL06 EthanL06 force-pushed the feature/sidebar-redesign branch from 859c2b2 to 0d73b13 Compare January 3, 2025 06:05
@EthanL06 EthanL06 reopened this Jan 3, 2025
@EthanL06 EthanL06 requested a review from IsaDavRod January 3, 2025 07:35
@EthanL06
Copy link
Contributor Author

EthanL06 commented Jan 3, 2025

Is it possible to try changing the width of the drag indicator so that it doesn't have extra empty space around the drag indicators? (if you see the image below, the drag indicator width should be like the purple rectangle, not the purple square since that adds extra space. The size of the icon should not change though, just the "boundaries" of the container the icon is in).

I attempted to implement this change, but when I decreased the width of the icon's container, it also caused the SVG icon to shrink. From what I understand, the only way to achieve this might be by modifying the viewBox property of the SVG (please feel free to correct me if I’m wrong). However, I don’t think this is the best approach because it would involve directly altering how the icon is rendered, which could lead to unintended visual inconsistencies.

src/views/components/calendar/CalendarSchedules.tsx Outdated Show resolved Hide resolved
src/views/components/common/ScheduleListItem.tsx Outdated Show resolved Hide resolved
src/views/components/calendar/Calendar.tsx Outdated Show resolved Hide resolved
src/views/components/calendar/Calendar.tsx Show resolved Hide resolved
src/views/components/calendar/CalendarFooter.tsx Outdated Show resolved Hide resolved
src/views/components/calendar/ResourceLinks.tsx Outdated Show resolved Hide resolved
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small change! Everything else looks perfect.

src/views/components/calendar/Calendar.tsx Outdated Show resolved Hide resolved
@EthanL06 EthanL06 requested a review from IsaDavRod January 8, 2025 16:03
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the Calendar Sidebar with the new Figma design
3 participants