feat: updated Text component to latest design specification #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samathingamajig
commented
Feb 3, 2024
Samathingamajig
commented
Feb 3, 2024
sghsri
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine this will change once we get UnoCSS/Tailwind working properly.
It expects colors and such to be passed in by className, so like
It can either be a span or a div element, which is determined by the standard "as" prop. I used a tagged union to be able to get all the properties of the respective element, that way you can use onClick, onMouseLeave, id, title, and more, all without needing to explicitly make that a prop in our code.