Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create icon helper #77

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

DhruvArora-03
Copy link
Member

Create helper function, takes in Status & classname --> returns corresponding Icon Component with classname applied

Copy link

github-actions bot commented Feb 5, 2024

Your pull request title did not conform to conventional commits standards. Our upcoming automated release pipeline will automatically determine
the proper release version based on your pull request title.
Cheat Sheet

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@DhruvArora-03 DhruvArora-03 changed the title Create icon helper feat: Create icon helper Feb 5, 2024
@Razboy20 Razboy20 requested a review from sghsri February 5, 2024 22:21
@Razboy20 Razboy20 merged commit 1b51d65 into Longhorn-Developers:main Feb 6, 2024
1 check passed
@DhruvArora-03 DhruvArora-03 deleted the icon-helper branch February 6, 2024 17:01
@DhruvArora-03 DhruvArora-03 restored the icon-helper branch February 6, 2024 17:01
@DhruvArora-03 DhruvArora-03 deleted the icon-helper branch February 6, 2024 17:01
doprz pushed a commit that referenced this pull request Mar 6, 2024
* create icon helper

* change getStatusIcon to StatusIcon react component

---------

Co-authored-by: Razboy20 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants